Ideas for Arc XP

Upgrade styled-components to v5

Fusion is using styled-components v4.4.1 and there have been a lot of improvements in v5 specifically around performance, ssr, and filtering props to be forwarded to the underlying dom node.

v5 was released without breaking changes, and we are specifically looking for the shouldForwardProp api introduced in v5.1.0, as it allows us to filter style props that would otherwise break amp validation.

  • Kenny Elshoff
  • Jul 22 2021
  • Shipped
  • Attach files
  • Admin
    Fatih Yildiz commented
    31 May 05:16pm

    We have upgraded styled-components to 5.x in the most recent Engine 3.3.1 release (which went live today).

  • Admin
    Fatih Yildiz commented
    23 Jul, 2021 06:26pm

    Hi Kenny, thank you for submitting this idea.

    We definitely would like to upgrade to newer version of styled components. Although we need to coordinate our internal teams to see the impact of the change before committing this into the upcoming release. We're definitely going to do this and I'll keep this thread posted when we commit to a release of includes styled components >5.1.x version.